-
Notifications
You must be signed in to change notification settings - Fork 17
Added Connectivity Testcases [Ethernet and Bluetooth] and one Kernel Testcase [shmbridge] #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments.
d21d64d
to
7c9039f
Compare
7c9039f
to
3bd98cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/qualcomm-linux/qcom-linux-testkit/pull/60/files#diff-ebc46adb66ac049c30cc1083b1ab13ac002617867bdfe2ee9c4ecaff8d5c53a9 clearly shows merge conflict.
Your PR currently includes several merged commits unrelated to your changes. Rebase your feature branch on top of the latest main. This will remove the unrelated history and make the PR eaiser to review and merge.
d638ac8
to
8562064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes. Remaining are looks good.
8562064
to
59bad2f
Compare
Resolved all the comments, please merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more minor change posted.
59bad2f
to
7284726
Compare
Resolved the comment by adding check success message for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left few more changes.
7284726
to
d0c663e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request changes to avoid unused declarations unless you plan to implement them shortly
This test validates the Ethernet interface (eth0) by checking its presence, bringing it up if necessary, and verifying connectivity via ping to 8.8.8.8. - Compliant with qcom-linux-testkit structure - Generates .res file for CI/CD - Uses functestlib logging and dependency checks Signed-off-by: Anil Yadav <anilyada@qti.qualcomm.com>
This test validates the Bluetooth controller by checking for the presence of bluetoothctl, ensuring bluetoothd is running, and toggling the controller power state using bluetoothctl. - Compliant with qcom-linux-testkit structure - Generates .res file for CI/CD - Uses functestlib logging and dependency checks Signed-off-by: Anil Yadav <anilyada@qti.qualcomm.com>
This test validates the encryption and access functionality of the shmbridge partition by formatting it, applying fscrypt encryption, and verifying data integrity through read/write operations. - Compliant with qcom-linux-testkit structure - Generates .res file for CI/CD - Uses functestlib logging and dependency checks Signed-off-by: Anil Yadav <anilyada@qti.qualcomm.com>
d0c663e
to
5ac7bde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request includes testcases and respective README.md file from two key suites Connectivity and Kernel, further details are given below:
1. Encrypted ext4 Mount Test (shmbridge)
fscryptctl
Runner/suites/Kernel/FunctionalArea/baseport/shmbridge/run.sh
2. Connectivity Test Scripts
These additions enhance the kernel-level validation coverage for secure storage and basic connectivity.
Signed-off-by: Anil Yadav anilyada@qti.qualcomm.com